Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the metodology to create HTTP clients to deliver webhooks #59

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Changing the metodology to create HTTP clients to deliver webhooks #59

merged 3 commits into from
Jan 27, 2024

Conversation

tsutomi
Copy link
Member

@tsutomi tsutomi commented Jan 27, 2024

  • Removal of the WebhookSenderClient base class
  • Reference to the IHttpClientFactory directly in the WebhookSender and WebhookVerifier classes to obtain instances of HttpClient per destination
  • Named destinations (URL by default)
  • WebhookDestinations now provide the Retry and Timeout policies for the delivery

@tsutomi tsutomi added the sender Issue related to the send capability label Jan 27, 2024
@tsutomi tsutomi self-assigned this Jan 27, 2024
@tsutomi tsutomi linked an issue Jan 27, 2024 that may be closed by this pull request
HttpClient Factory for the Webhook Sender #58
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

10 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsutomi tsutomi merged commit 69bf25d into main Jan 27, 2024
2 checks passed
@tsutomi tsutomi deleted the 58-httpclient-factory-for-the-webhook-sender branch January 27, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tsutomi tsutomi

Labels
sender Issue related to the send capability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HttpClient Factory for the Webhook Sender
1 participant
@tsutomi